app-rules: the shared 7bit_ascii exclusion follows samples-controls' new ports - #56
Merged
Merged
Conversation
…new ports Eleven more sample ports in samples-controls carry non-ASCII characters that come straight from the original demo-kit mock data - `9.600 x 9.600 dpi` with a multiplication sign, en dashes in UI5's own bootstrap prose, an ellipsis in a navigation label. That is the same reason the twenty-one names already on this list are there, and scripts/data-fidelity.mjs would reject ASCII replacements. abap2UI5 is the source of this block; copied from there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RRPQ84UVzuc2HqRLPt1T1V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line in
abaplint.jsonc: eleven more names on the7bit_asciiexclusion of the shared app rule set.Eleven new sample ports in
samples-controlscarry non-ASCII characters that come straight from the original demo-kit mock data —9.600 × 9.600 dpiwith a multiplication sign, en dashes in UI5's own bootstrap prose, an ellipsis in a navigation label. That is exactly the reason the twenty-one names already on this list are there, and the comment above the block already says it: those ports' data is compared against the original byscripts/data-fidelity.mjs, so replacing the characters with ASCII would fail that gate instead.abap2UI5is the source of this block, and it has moved: abap2UI5/abap2UI5#2654. Itscheck:sharedgate is red on all three consumers until each copies the new value — this issamples-stack' copy, and it is byte-identical to the one in abap2UI5/samples#800 and to the value already on abap2UI5/samples-controls#143.How to test
npm run check:app-rules— green here against anabap2UI5checkout carrying #2654.Note the ordering: in CI that same gate reads
abap2UI5@main, so this pull request stays red until #2654 merges. The circularity is unavoidable in either direction — the source has to move first, and the gate on this side reports the gap while it is open.🤖 Generated with Claude Code
https://claude.ai/code/session_01RRPQ84UVzuc2HqRLPt1T1V
Generated by Claude Code